Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IconButtonLink: support active state #3809

Merged
merged 6 commits into from
Oct 18, 2024
Merged

IconButtonLink: support active state #3809

merged 6 commits into from
Oct 18, 2024

Conversation

AlbertCarreras
Copy link
Contributor

IconButtonLink: support active state
Screenshot by Dropbox Capture

@AlbertCarreras AlbertCarreras requested a review from a team as a code owner October 17, 2024 23:32
@AlbertCarreras AlbertCarreras added the minor release Minor release label Oct 17, 2024
@netlify Netlify
Copy link

netlify bot commented Oct 17, 2024

✅ Deploy Preview for gestalt ready!

Name Link
🔨 Latest commit dc8304e
🔍 Latest deploy log https://app.netlify.com/sites/gestalt/deploys/67119eacafa0d0000845756a
😎 Deploy Preview https://deploy-preview-3809--gestalt.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@AlbertCarreras AlbertCarreras enabled auto-merge (squash) October 17, 2024 23:39
@netlify Netlify
Copy link

netlify bot commented Oct 17, 2024 •
edited
Loading

✅ Deploy Preview for gestalt ready!

Name Link
🔨 Latest commit c903ede
🔍 Latest deploy log https://app.netlify.com/sites/gestalt/deploys/67129eb417e0c10008bd773a
😎 Deploy Preview https://deploy-preview-3809--gestalt.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

jordan-cutler
jordan-cutler reviewed Oct 18, 2024
View reviewed changes
Copy link

@jordan-cutler jordan-cutler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! Thanks so much for this. I don't have permissions to approve but LGTM. Just left a couple comments on the label

docs/examples/iconbuttonlink/active.tsx Outdated
return (
<Flex alignItems="center" height="100%" justifyContent="center" width="100%">
<IconButtonLink
accessibilityLabel=""
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we add a label?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

DONE

docs/examples/iconbuttonlink/disabled.tsx Outdated
return (
<Flex alignItems="center" height="100%" justifyContent="center" width="100%">
<IconButtonLink
accessibilityLabel=""
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we add a label?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

DONE

docs/examples/iconbuttonlink/enabled.tsx Outdated
return (
<Flex alignItems="center" height="100%" justifyContent="center" width="100%">
<IconButtonLink
accessibilityLabel=""
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we add a label?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

DONE

docs/examples/iconbuttonlink/disabled.tsx Outdated
target="blank"
/>
<IconButtonLink
accessibilityLabel=""
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we add a label?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

DONE

@AlbertCarreras AlbertCarreras merged commit 150af42 into pinterest:master Oct 18, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jordan-cutler jordan-cutler jordan-cutler left review comments

Assignees
No one assigned
Labels
minor release Minor release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AlbertCarreras @jordan-cutler